feat(ToggleSwitch): Add name attribute to ToggleSwitch #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienguezou
force-pushed
the
add-toggle-name
branch
from
4ee9b91 to
b40f490
Compare
garronej
reviewed
Apr 20, 2023
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
Collaborator
|
Thank you! |
Collaborator
|
Maybe we should have |
Collaborator
Author
|
Thanks for the review and merge. Yes I hesitated to add a nativeInputProps. I will try to do it |
sbourdon13
pushed a commit
to sbourdon13/react-dsfr
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a name attribute to ToggleSwitch input.
Permit to handle the input like a normal html input when a form is submitted.